[coreboot] New patch to review for coreboot: a844fb6 bootblock: Guard CMOS rewrite in disable/enable RTC

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Fri Nov 16 10:41:19 CET 2012


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1869

-gerrit

commit a844fb6d6da677b11544dae3fc094f7fcefe4745
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Thu Nov 15 14:57:27 2012 +0100

    bootblock: Guard CMOS rewrite in disable/enable RTC
    
    This ensures that there's only one disable/enable cycle for
    the entire rewrite instead for every single byte.
    
    Change-Id: Ic06e6dcb08976d158ff784660838c0fbad875176
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
---
 src/arch/x86/include/bootblock_common.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/arch/x86/include/bootblock_common.h b/src/arch/x86/include/bootblock_common.h
index c9674f4..4a128bc 100644
--- a/src/arch/x86/include/bootblock_common.h
+++ b/src/arch/x86/include/bootblock_common.h
@@ -27,9 +27,11 @@ static void sanitize_cmos(void)
 		unsigned char *cmos_default = (unsigned char*)walkcbfs("cmos.default");
 		if (cmos_default) {
 			int i;
+			cmos_disable_rtc();
 			for (i = 14; i < 128; i++) {
 				cmos_write(cmos_default[i], i);
 			}
+			cmos_enable_rtc();
 		}
 	}
 }




More information about the coreboot mailing list