[coreboot] Patch merged into coreboot/master: 5079a0d Remove assembly coded log2 function

gerrit at coreboot.org gerrit at coreboot.org
Wed Nov 28 07:57:18 CET 2012


the following patch was just integrated into master:
commit 5079a0d32f2824445cf593dfbcb65598eaa97dee
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Tue Nov 27 11:32:38 2012 -0800

    Remove assembly coded log2 function
    
    As we move to supporting other systems we need to get rid of assembly
    where we can. The log2 function in src/lib is identical to the assembly
    one (tested for all 32-bit signed integers :-) and takes about 10 ns
    to run as opposed to 5ns for the non-portable assembly version. While speed
    is good, I think we can spare the 15 ns or so we add to boot time
    by using the C version only.
    
    Change-Id: Icafa565eae282c85fa5fc01b3bd1f110cd9aaa91
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
    Reviewed-on: http://review.coreboot.org/1928
    Tested-by: build bot (Jenkins)

Build-Tested: build bot (Jenkins) at Wed Nov 28 01:33:26 2012, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Wed Nov 28 07:57:08 2012, giving +2
See http://review.coreboot.org/1928 for details.

-gerrit




More information about the coreboot mailing list