[coreboot] New patch to review for coreboot: d32cde9 libpayload: Fix lookup by label in CMOS layouts

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Thu Nov 29 11:09:03 CET 2012


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1941

-gerrit

commit d32cde99c4b52c57bb7afa8fa16d5820212bf2b4
Author: Nico Huber <nico.huber at secunet.com>
Date:   Fri Nov 9 18:12:21 2012 +0100

    libpayload: Fix lookup by label in CMOS layouts
    
    The condition to compare the labels was twisted.
    
    Change-Id: I34a665aa87e2ff0480eda0f249bbbea8a8fe68d8
    Signed-off-by: Nico Huber <nico.huber at secunet.com>
---
 payloads/libpayload/drivers/options.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c
index d15d81b..d497c0a 100644
--- a/payloads/libpayload/drivers/options.c
+++ b/payloads/libpayload/drivers/options.c
@@ -243,7 +243,7 @@ static struct cb_cmos_enums *lookup_cmos_enum_core(struct cb_cmos_option_table *
 		cmos_enum;
 		cmos_enum = next_cmos_enum_of_id(cmos_enum, config_id)) {
 		if (((value == NULL) || (cmos_enum->value == *value)) &&
-		    ((text == NULL) || (memcmp((const char*)cmos_enum->text, text, len)))) {
+		    ((text == NULL) || (memcmp((const char*)cmos_enum->text, text, len) == 0))) {
 			return cmos_enum;
 		}
 	}




More information about the coreboot mailing list