[coreboot] New patch to review for coreboot: 5498b3b Clarify that _ROM_RUN Kconfig options control if ROMs are run by coreboot

[Peter Stuge (peter@stuge.se)]

Peter Stuge (peter at stuge.se) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1636

-gerrit

commit 5498b3b93e8107a71692b41a7dc49c65fd878a9e
Author: Peter Stuge <peter at stuge.se>
Date:   Sat Oct 27 13:45:51 2012 +0200

    Clarify that _ROM_RUN Kconfig options control if ROMs are run by coreboot
    
    Also clarify that enabling these options is generally not desirable if
    using SeaBIOS as payload since the option ROMs are run by SeaBIOS with
    more complete BIOS interrupt services available than coreboot.
    
    Change-Id: Ic4a45c351a4933aedad08d70a088eab04ca35b05
    Signed-off-by: Peter Stuge <peter at stuge.se>
---
 src/devices/Kconfig | 43 +++++++++++++++++++++++++++++++++----------
 1 file changed, 33 insertions(+), 10 deletions(-)

diff --git a/src/devices/Kconfig b/src/devices/Kconfig
index d83d551..013ab9a 100644
--- a/src/devices/Kconfig
+++ b/src/devices/Kconfig
@@ -23,37 +23,60 @@ config VGA_ROM_RUN
 	bool "Run VGA Option ROMs"
 	default y
 	help
-	  Execute VGA Option ROMs, if found. This is required to enable
-	  PCI/AGP/PCI-E video cards.
+	  Execute VGA Option ROMs in coreboot if found. This is required
+	  to enable PCI/AGP/PCI-E video cards when not using a SeaBIOS
+	  payload.
+
+	  When using a SeaBIOS payload it runs all option ROMs with much
+	  more complete BIOS interrupt services available than coreboot,
+	  which some option ROMs require in order to function correctly.
+
+	  If unsure, say N when using SeaBIOS as payload, Y otherwise.
 
 config S3_VGA_ROM_RUN
 	bool "Re-run VGA Option ROMs on S3 resume"
 	default y
 	depends on VGA_ROM_RUN && HAVE_ACPI_RESUME
 	help
-	  Execute VGA Option ROMs when coming out of an S3 resume.
+	  Execute VGA Option ROMs in coreboot when resuming from S3 suspend.
+
+	  When using a SeaBIOS payload it runs all option ROMs with much
+	  more complete BIOS interrupt services available than coreboot,
+	  which some option ROMs require in order to function correctly.
+
+	  If unsure, say N when using SeaBIOS as payload, Y otherwise.
 
 config PCI_ROM_RUN
 	bool "Run non-VGA Option ROMs"
 	default y
 	help
-	  Execute non-VGA PCI Option ROMs, if found.
+	  Execute non-VGA PCI Option ROMs in coreboot if found.
 
 	  Examples include IDE/SATA controller Option ROMs and Option ROMs
 	  for network cards (NICs).
 
+	  When using a SeaBIOS payload it runs all option ROMs with much
+	  more complete BIOS interrupt services available than coreboot,
+	  which some option ROMs require in order to function correctly.
+
+	  If unsure, say N when using SeaBIOS as payload, Y otherwise.
+
 config ON_DEVICE_ROM_RUN
 	bool "Run Option ROMs on PCI devices"
 	default y
 	help
-	  Execute Option ROMs that are stored on PCI/PCIe/AGP devices.
+	  Execute Option ROMs stored on PCI/PCIe/AGP devices in coreboot.
+
+	  If disabled, only Option ROMs stored in CBFS will be executed by
+	  coreboot. If you are concerned about security, you might want to
+	  disable this option, but it might leave your system in a state of
+	  degraded functionality.
 
-	  If disabled, only Option ROMs stored in CBFS will be executed. If
-	  you are concerned about security, you might want to disable this
-	  option, but it might leave your system in a state of degraded
-	  functionality.
+	  When using a SeaBIOS payload it runs all option ROMs with much
+	  more complete BIOS interrupt services available than coreboot,
+	  which some option ROMs require in order to function correctly.
 
-	  If unsure, say Y
+	  If unsure, say N when using SeaBIOS as payload, Y otherwise.
 
 choice
 	prompt "Option ROM execution type"