[coreboot] Integrating FILO with Coreboot

Stojsavljevic, Zoran zoran.stojsavljevic at intel.com
Mon Aug 19 09:37:55 CEST 2013


Hello to Coreboot community,

Went to filo Coreboot page: http://www.coreboot.org/FILO

As written, executed the following:
cd coreboot/payloads
git clone http://review.coreboot.org/p/filo.git
cd filo
make menuconfig

make produces several errors, on the way, so I did temporarily fix it:

[zoran at localhost filo]$ diff -c  Makefile Makefile.orig
*** Makefile    2013-08-16 14:54:09.314253711 +0200
--- Makefile.orig       2013-08-16 15:17:06.190593523 +0200
***************
*** 91,98 ****
  ARCHDIR-$(CONFIG_TARGET_I386) := x86

  CPPFLAGS := -nostdinc -imacros $(obj)/config.h
! ## CPPFLAGS += -I$(INCPAYLOAD) -I$(INCPAYLOAD)/$(ARCHDIR-y)
! CPPFLAGS += -I$(INCPAYLOAD) -I$(INCPAYLOAD)/i386 -I$(INCPAYLOAD)/i386/arch
  CPPFLAGS += -I$(ARCHDIR-y)/include -Iinclude -I$(obj)
  CPPFLAGS += -I$(GCCINCDIR)

--- 91,97 ----
  ARCHDIR-$(CONFIG_TARGET_I386) := x86

  CPPFLAGS := -nostdinc -imacros $(obj)/config.h
! CPPFLAGS += -I$(INCPAYLOAD) -I$(INCPAYLOAD)/$(ARCHDIR-y)
  CPPFLAGS += -I$(ARCHDIR-y)/include -Iinclude -I$(obj)
  CPPFLAGS += -I$(GCCINCDIR)

And then I got the following errors (end of compilation):
CC      build/fs/fsys_reiserfs.o
  CC      build/fs/fsys_iso9660.o
  CC      build/fs/fsys_cbfs.o
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/fs/fsys_cbfs.c: In function 'cbfs_dir':
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/fs/fsys_cbfs.c:62:3: warning: implicit declaration of function 'be32toh' [-Wimplicit-function-declaration]
  CC      build/drivers/ide_new.o
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_error':
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:182:17: warning: variable 'old_cdb' set but not used [-Wunused-but-set-variable]
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:162:16: warning: variable 'err' set but not used [-Wunused-but-set-variable]
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_atapi_packet':
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:563:17: error: 'struct request_sense' has no member named 'sense_key'
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:565:24: error: 'struct request_sense' has no member named 'sense_key'
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_atapi_drive_ready':
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:679:2: warning: implicit declaration of function 'be32toh' [-Wimplicit-function-declaration]
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:625:6: warning: unused variable 'i' [-Wunused-variable]
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_read_ata_chs':
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:742:27: error: 'struct ata_sector' has no member named 'low'
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:733:20: warning: variable 'ata_sector' set but not used [-Wunused-but-set-variable]
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_read_ata_lba48':
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:795:27: error: 'struct ata_sector' has no member named 'low'
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:796:27: error: 'struct ata_sector' has no member named 'high'
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:784:20: warning: variable 'ata_sector' set but not used [-Wunused-but-set-variable]
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'ob_ide_fixup_id':
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:887:2: warning: implicit declaration of function 'le16toh' [-Wimplicit-function-declaration]
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:888:2: warning: implicit declaration of function 'le32toh' [-Wimplicit-function-declaration]
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c: In function 'find_ide_controller':
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:1279:19: warning: variable 'device' set but not used [-Wunused-but-set-variable]
/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/drivers/ide_new.c:1279:11: warning: variable 'vendor' set but not used [-Wunused-but-set-variable]
make: *** [/home/zoran/projects/cc2_dev_coreboot/coreboot/payloads/filo/build/drivers/ide_new.o] Error 1

Any idea why this is happening? Did somehow I misconfigured coreboot/payloads/libpayload (it was compiled prior these steps)?

Thank you,
Zoran
_______
Most of The Time you should be "intel inside" to be capable to think "out of the box".

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20130819/628be144/attachment.html>


More information about the coreboot mailing list