[coreboot] New patch to review for coreboot: 1f4e9a4 romcc: Don't use user overridable romcc flags for bootblock

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Sat Feb 9 15:29:19 CET 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2335

-gerrit

commit 1f4e9a4fb86e0672ae0121582d93eb9495a04a58
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sat Feb 9 14:35:55 2013 +0100

    romcc: Don't use user overridable romcc flags for bootblock
    
    The bootblock is typically run before fpu/mmx/sse setup, so
    we can't rely on -mcpu=p4 and the like to increase the
    register space.
    
    bootblock_romccflags does that for SSE, but they're controlled
    separately.
    
    Change-Id: I2b0609ac18b2394a319bf9bbbee1f77d2e758127
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/arch/x86/Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index 419507b..da03693 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -330,7 +330,7 @@ $(objgenerated)/bootblock.inc: $(src)/arch/x86/init/$(subst ",,$(CONFIG_BOOTBLOC
 	@printf "    ROMCC      $(subst $(obj)/,,$(@))\n"
 	$(CC) $(INCLUDES) -MM -MT$(objgenerated)/bootblock.inc \
 		$< > $(objgenerated)/bootblock.inc.d
-	$(ROMCC) -c -S $(bootblock_romccflags) $(ROMCCFLAGS) -I. $(INCLUDES) $< -o $@
+	$(ROMCC) -c -S $(bootblock_romccflags) -I. $(INCLUDES) $< -o $@
 
 $(objcbfs)/bootblock.debug: $(objgenerated)/bootblock.o $(objgenerated)/bootblock.ld
 	@printf "    LINK       $(subst $(obj)/,,$(@))\n"



More information about the coreboot mailing list