[coreboot] Patch merged into coreboot/master: 601b275 ARMV7: minor tweaks to inter-stage calling and payload handling.

gerrit at coreboot.org gerrit at coreboot.org
Wed Feb 20 20:49:17 CET 2013


the following patch was just integrated into master:
commit 601b27596ffdf526adf5b41c1f8366a5fdddc554
Author: Ronald G. Minnich <rminnich at google.com>
Date:   Wed Feb 20 09:24:29 2013 -0800

    ARMV7: minor tweaks to inter-stage calling and payload handling.
    
    Payloads, by design, can return. There's lots of mechanism in the payload code
    to support it, and the chooser payload relies on it. Hence, we should not mark
    the function call in exit_stage as noreturn.
    
    Not all ARM have unified caches, and it's not always easy to tell what
    to do. So we are very paranoid. Before we call between stages, we
    should carefully flush the dcache to memory and invalidate the icache.
    This may be more than is necessary on all architectures but it
    doesn't really hurt for the most part.
    
    So compile cache management code into all stages, and call the
    flush dcache/invalidate icache from all stages.
    
    Change-Id: Ib9cc625c4dfd2d7d4b3c69a74686cc655a9d6484
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
    Reviewed-on: http://review.coreboot.org/2462
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Wed Feb 20 19:08:39 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Wed Feb 20 20:33:25 2013, giving +2
See http://review.coreboot.org/2462 for details.

-gerrit



More information about the coreboot mailing list