[coreboot] Patch set updated for coreboot: 4109da0 AMD based boards: platform_cfg.h: Replace `_*BOARDNAME*_CFG_H_` with `_PLATFORM_CFG_H_`

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Fri Feb 22 13:50:46 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2464

-gerrit

commit 4109da0b0f9b281f83b64f5cb94c3561e0b2d742
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date:   Wed Feb 20 21:24:20 2013 +0100

    AMD based boards: platform_cfg.h: Replace `_*BOARDNAME*_CFG_H_` with `_PLATFORM_CFG_H_`
    
    Reduce unnecessary differences between AMD based boards only
    using the file `platform_cfg.h` for configuration making them
    a little bit easier to compare.
    
    Inagua & co. mention the board name in several places which are really not
    that board specific.  Sometimes people even forget to change it:
    Union Station’s platform_cfg.h starts with "#ifndef _PERSIMMON_CFG_H_".
    Funny.  Change that to "_PLATFORM_CFG_H_" everywhere.
    
    The following command was used.
    
        $ find . -name platform_cfg.h | xargs sed -i '/_CFG_H_/s/_.*_/_PLATFORM_CFG_H_/'
    
    More boards seem to use that kind of naming (`git grep _CFG_H_`)
    but it is not certain that this will not break anything as for
    example the board AMD Dinar also has header files for
    configuration stuff for the north- and southbridge.
    
        $ git grep _CFG_H_
        […]
        src/mainboard/amd/dinar/platform_cfg.h:#ifndef _PLATFORM_CFG_H_
        src/mainboard/amd/dinar/platform_cfg.h:#define _PLATFORM_CFG_H_
        src/mainboard/amd/dinar/platform_cfg.h:#endif //_PLATFORM_CFG_H_
        src/mainboard/amd/dinar/rd890_cfg.h:#ifndef  _RD890_CFG_H_
        src/mainboard/amd/dinar/rd890_cfg.h:#define _RD890_CFG_H_
        src/mainboard/amd/dinar/rd890_cfg.h:#endif //_RD890_CFG_H_
        src/mainboard/amd/dinar/sb700_cfg.h:#ifndef _SB700_CFG_H_
        src/mainboard/amd/dinar/sb700_cfg.h:#define _SB700_CFG_H_
        src/mainboard/amd/dinar/sb700_cfg.h:#endif //_SB700_CFG_H
        […]
    
    Change-Id: Ida15fa6a7adfc770240ac30e795946000dae3f16
    Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/advansus/a785e-i/platform_cfg.h  | 4 ++--
 src/mainboard/amd/inagua/platform_cfg.h        | 4 ++--
 src/mainboard/amd/persimmon/platform_cfg.h     | 4 ++--
 src/mainboard/amd/south_station/platform_cfg.h | 4 ++--
 src/mainboard/amd/torpedo/platform_cfg.h       | 4 ++--
 src/mainboard/amd/union_station/platform_cfg.h | 4 ++--
 src/mainboard/asrock/e350m1/platform_cfg.h     | 4 ++--
 src/mainboard/asus/m5a88-v/platform_cfg.h      | 4 ++--
 src/mainboard/avalue/eax-785e/platform_cfg.h   | 4 ++--
 9 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/src/mainboard/advansus/a785e-i/platform_cfg.h b/src/mainboard/advansus/a785e-i/platform_cfg.h
index 8b90d57..e2d9412 100644
--- a/src/mainboard/advansus/a785e-i/platform_cfg.h
+++ b/src/mainboard/advansus/a785e-i/platform_cfg.h
@@ -18,8 +18,8 @@
  */
 
 
-#ifndef _A785E_I_CFG_H_
-#define _A785E_I_CFG_H_
+#ifndef _PLATFORM_CFG_H_
+#define _PLATFORM_CFG_H_
 
 /**
  * @def BIOS_SIZE_1M
diff --git a/src/mainboard/amd/inagua/platform_cfg.h b/src/mainboard/amd/inagua/platform_cfg.h
index 88526db..d29a7a5 100644
--- a/src/mainboard/amd/inagua/platform_cfg.h
+++ b/src/mainboard/amd/inagua/platform_cfg.h
@@ -18,8 +18,8 @@
  */
 
 
-#ifndef _INAGUA_CFG_H_
-#define _INAGUA_CFG_H_
+#ifndef _PLATFORM_CFG_H_
+#define _PLATFORM_CFG_H_
 
 /**
  * @def BIOS_SIZE_1M
diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h
index e773f75..6590e4e 100644
--- a/src/mainboard/amd/persimmon/platform_cfg.h
+++ b/src/mainboard/amd/persimmon/platform_cfg.h
@@ -18,8 +18,8 @@
  */
 
 
-#ifndef _PERSIMMON_CFG_H_
-#define _PERSIMMON_CFG_H_
+#ifndef _PLATFORM_CFG_H_
+#define _PLATFORM_CFG_H_
 
 /**
  * @def BIOS_SIZE_1M
diff --git a/src/mainboard/amd/south_station/platform_cfg.h b/src/mainboard/amd/south_station/platform_cfg.h
index a5f9838..d712875 100644
--- a/src/mainboard/amd/south_station/platform_cfg.h
+++ b/src/mainboard/amd/south_station/platform_cfg.h
@@ -18,8 +18,8 @@
  */
 
 
-#ifndef _PERSIMMON_CFG_H_
-#define _PERSIMMON_CFG_H_
+#ifndef _PLATFORM_CFG_H_
+#define _PLATFORM_CFG_H_
 
 /**
  * @def BIOS_SIZE_1M
diff --git a/src/mainboard/amd/torpedo/platform_cfg.h b/src/mainboard/amd/torpedo/platform_cfg.h
index a6d02e8..6c27249 100644
--- a/src/mainboard/amd/torpedo/platform_cfg.h
+++ b/src/mainboard/amd/torpedo/platform_cfg.h
@@ -18,8 +18,8 @@
  */
 
 
-#ifndef _SB900_CFG_H_
-#define _SB900_CFG_H_
+#ifndef _PLATFORM_CFG_H_
+#define _PLATFORM_CFG_H_
 
 #include <stdint.h>
 
diff --git a/src/mainboard/amd/union_station/platform_cfg.h b/src/mainboard/amd/union_station/platform_cfg.h
index a5f9838..d712875 100644
--- a/src/mainboard/amd/union_station/platform_cfg.h
+++ b/src/mainboard/amd/union_station/platform_cfg.h
@@ -18,8 +18,8 @@
  */
 
 
-#ifndef _PERSIMMON_CFG_H_
-#define _PERSIMMON_CFG_H_
+#ifndef _PLATFORM_CFG_H_
+#define _PLATFORM_CFG_H_
 
 /**
  * @def BIOS_SIZE_1M
diff --git a/src/mainboard/asrock/e350m1/platform_cfg.h b/src/mainboard/asrock/e350m1/platform_cfg.h
index 7fa9c23..1b09590 100644
--- a/src/mainboard/asrock/e350m1/platform_cfg.h
+++ b/src/mainboard/asrock/e350m1/platform_cfg.h
@@ -18,8 +18,8 @@
  */
 
 
-#ifndef _E350M1_CFG_H_
-#define _E350M1_CFG_H_
+#ifndef _PLATFORM_CFG_H_
+#define _PLATFORM_CFG_H_
 
 /**
  * @def BIOS_SIZE_1M
diff --git a/src/mainboard/asus/m5a88-v/platform_cfg.h b/src/mainboard/asus/m5a88-v/platform_cfg.h
index 40741d9..e2d9412 100644
--- a/src/mainboard/asus/m5a88-v/platform_cfg.h
+++ b/src/mainboard/asus/m5a88-v/platform_cfg.h
@@ -18,8 +18,8 @@
  */
 
 
-#ifndef _M5A88_V_CFG_H_
-#define _M5A88_V_CFG_H_
+#ifndef _PLATFORM_CFG_H_
+#define _PLATFORM_CFG_H_
 
 /**
  * @def BIOS_SIZE_1M
diff --git a/src/mainboard/avalue/eax-785e/platform_cfg.h b/src/mainboard/avalue/eax-785e/platform_cfg.h
index fd02f7d..bea852d 100644
--- a/src/mainboard/avalue/eax-785e/platform_cfg.h
+++ b/src/mainboard/avalue/eax-785e/platform_cfg.h
@@ -18,8 +18,8 @@
  */
 
 
-#ifndef _EAX_785E_CFG_H_
-#define _EAX_785E_CFG_H_
+#ifndef _PLATFORM_CFG_H_
+#define _PLATFORM_CFG_H_
 
 /**
  * @def BIOS_SIZE_1M



More information about the coreboot mailing list