[coreboot] New patch to review for coreboot: b315068 QEMU x86: northbridge.c: Name enabling device function to `northbridge_enable`
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Sun Feb 24 14:32:25 CET 2013
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2496
-gerrit
commit b315068b03892d31fb3284b6ca388b0e7c7c0b13
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Sun Feb 24 14:27:03 2013 +0100
QEMU x86: northbridge.c: Name enabling device function to `northbridge_enable`
Similar to the discussion on the coreboot list [1]
Am Freitag, den 22.02.2013, 02:17 +0100 schrieb Peter Stuge:
[…]
> Function names should try to be descriptive. "enable_dev" is not very
> descriptive. I like "mainboard_enable" because it makes output such
> as
>
> printk("%s: foo", __func__);
>
> useful.
rename the function for the northbridge to `northbridge_enable`.
[1] http://www.coreboot.org/pipermail/coreboot/2013-February/074549.html
Change-Id: I262311ec511e394550330214621b8c37780c1d4e
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
src/mainboard/emulation/qemu-x86/northbridge.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/emulation/qemu-x86/northbridge.c b/src/mainboard/emulation/qemu-x86/northbridge.c
index 7c36c0a..3e7fbb9 100644
--- a/src/mainboard/emulation/qemu-x86/northbridge.c
+++ b/src/mainboard/emulation/qemu-x86/northbridge.c
@@ -135,7 +135,7 @@ static struct device_operations pci_domain_ops = {
#endif
};
-static void enable_dev(struct device *dev)
+static void northbridge_enable(struct device *dev)
{
/* Set the operations if it is a special bus type */
if (dev->path.type == DEVICE_PATH_DOMAIN) {
@@ -146,5 +146,5 @@ static void enable_dev(struct device *dev)
struct chip_operations mainboard_emulation_qemu_x86_ops = {
CHIP_NAME("QEMU Northbridge")
- .enable_dev = enable_dev,
+ .enable_dev = northbridge_enable,
};
More information about the coreboot
mailing list