[coreboot] QA: Notification of newly introduced and fixed warnings

[Paul Menzel]

Am Sonntag, den 24.02.2013, 13:34 +0100 schrieb Patrick Georgi:
> Am 2013-02-24 13:28, schrieb Paul Menzel:
> > Currently this is only possible if a board is warning free and -Werror
> > is passed to the compiler by setting the Kconfig option
> > WARNINGS_ARE_ERRORS to true so the the build aborts on new warnings.
> And that's what we should aim for. The introduction of 
> WARNINGS_ARE_ERRORS was for AGESA boards. Since it seems that we can 
> touch AGESA now, there's no need to keep this special provision around 
> for much longer.

True. But as we are not there yet and I just found out that Jenkins
already checks for fixed and introduced warnings [1], maybe this could
be added nevertheless to the Jenkins report Gerrit displays.

> One other AGESA provision we could kick out is the CAR globals 
> exception: For all boards except AGESA, using global variables in 
> romstage breaks the build unless they marked as CAR globals (in which 
> case they're moved into CAR space).
> AGESA has its own mechanism for doing so (which is much more crude, you 
> simply reserve some CAR space and hope it's enough. coreboot's 
> implementation has byte-precision) that we could replace.
> 
> > Does somebody have experience with this? It would certainly be nice 
> > and should be doable automatically.
>
> The main problem is that jenkins' coreboot-gerrit task is non-linear: 
> Introduce tons of warnings with one proposed change in gerrit, and the 
> next change build-tested by jenkins has no problems to pass...

Sorry, I did not understand. Could you give an example? If every build
is done from master and the patches with dependencies then this should
not be a problem, should not it?


Thanks,

Paul


[1] http://qa.coreboot.org/job/coreboot-gerrit/4857/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20130224/b830c600/attachment.sig>