[coreboot] Patch merged into coreboot/master: 030902b AGESA: skip s3_resume.h if CONFIG_HAVE_ACPI_RESUME is disabled

gerrit at coreboot.org gerrit at coreboot.org
Tue Feb 26 23:11:00 CET 2013


the following patch was just integrated into master:
commit 030902b774c672df217d9862fe73fade9c5265b1
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date:   Tue Feb 26 12:37:22 2013 +0100

    AGESA: skip s3_resume.h if CONFIG_HAVE_ACPI_RESUME is disabled
    
    Commit »AMD S3: Introduce Kconfig variable 'S3_DATA_SIZE'« (22ec9f9a) [1]
    introduced a check throwing an error if S3_DATA_SIZE isn't big enough.
    
    However without CONFIG_HAVE_ACPI_RESUME the variable S3_DATA_SIZE
    isn't defined at all and compilation will fail if s3_resume.h is
    included.
    
    This patch makes it again possible turn off HAVE_ACPI_RESUME relatively
    easily in Parmer/Thatcher/Persimmon's Kconfig if you don't care about S3
    and don't want flash writes on every boot.
    
    [1] http://review.coreboot.org/2383
    
    Change-Id: I999e4b7634bf172d8380fd14cba6f7f03468fee3
    Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
    Reviewed-by: Dave Frodin <dave.frodin at se-eng.com>
    Reviewed-by: Marc Jones <marcj303 at gmail.com>
    Reviewed-on: http://review.coreboot.org/2528
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: build bot (Jenkins)

Build-Tested: build bot (Jenkins) at Tue Feb 26 22:57:06 2013, giving +1
See http://review.coreboot.org/2528 for details.

-gerrit



More information about the coreboot mailing list