[coreboot] New patch to review for coreboot: 341619e selfboot: Report correct entry point address in debug message.

Hung-Te Lin (hungte@chromium.org) gerrit at coreboot.org
Wed Feb 27 10:01:50 CET 2013


Hung-Te Lin (hungte at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2535

-gerrit

commit 341619e6f05a1f88c43be3f783a1b7fc2f4c0443
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Wed Feb 27 16:38:38 2013 +0800

    selfboot: Report correct entry point address in debug message.
    
    Entry point in payload segment header is a 64 bit integer (ntohll). The debug
    message is currently reading that as a 32 bit integer (which will produce
    00000000 for most platforms).
    
    Change-Id: I931072bbb82c099ce7fae04f15c8a35afa02e510
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
---
 src/lib/selfboot.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c
index 56124da..d64ba4c 100644
--- a/src/lib/selfboot.c
+++ b/src/lib/selfboot.c
@@ -346,7 +346,8 @@ static int build_self_segment_list(
 			break;
 
 		case PAYLOAD_SEGMENT_ENTRY:
-			printk(BIOS_DEBUG, "  Entry Point 0x%p\n", (void *) ntohl((u32) segment->load_addr));
+			printk(BIOS_DEBUG, "  Entry Point 0x%p\n",
+			       (void *)(intptr_t)ntohll(segment->load_addr));
 			*entry =  ntohll(segment->load_addr);
 			/* Per definition, a payload always has the entry point
 			 * as last segment. Thus, we use the occurence of the



More information about the coreboot mailing list