[coreboot] New patch to review for coreboot: 555bf7d Clean up ARMv7 architecture Kconfig

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Jan 4 19:14:08 CET 2013


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2101

-gerrit

commit 555bf7db826824c0166d613753ea77e794964968
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Fri Jan 4 10:11:59 2013 -0800

    Clean up ARMv7 architecture Kconfig
    
    There was a misuse of bool that would cause the dcache policy to not be
    set up correctly, but instead present options "y" and "n" in the Kconfig
    menu.
    
    Also, TINY_BOOTBLOCK was removed a while ago, everything is
    TINY_BOOTBLOCK now. Hence remove the option.
    
    Change-Id: I5c28ac828955c69614c7bdaf106f79db51e68723
    Signed-off-by: Stefan Reinauer <reinauer at google.com>
---
 src/arch/armv7/Kconfig | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/arch/armv7/Kconfig b/src/arch/armv7/Kconfig
index f92911d..65de2d5 100644
--- a/src/arch/armv7/Kconfig
+++ b/src/arch/armv7/Kconfig
@@ -34,7 +34,6 @@ config BOOTBLOCK_SOURCE
 config UPDATE_IMAGE
 	bool "Update existing coreboot.rom image"
 	default n
-	depends on TINY_BOOTBLOCK
 	help
 	  If this option is enabled, no new coreboot.rom file
 	  is created. Instead it is expected that there already
@@ -47,9 +46,11 @@ config BOOTBLOCK_SOC_INIT
 # FIXME: Should cache policy be set on a per-CPU basis?
 # FIXME(dhendrix): Stefan sayz to make a smart decision and not prompt the user.
 config ARM_DCACHE_POLICY_WRITEBACK
-	bool y
+	bool
+	default y
 
 config ARM_DCACHE_POLICY_WRITETHROUGH
-	bool n
+	bool
+	default n
 
 endmenu



More information about the coreboot mailing list