[coreboot] Patch merged into coreboot/master: 73e86a8 F15tn: Fix all warnings, enable warnings as errors

gerrit at coreboot.org gerrit at coreboot.org
Tue Jan 22 12:17:07 CET 2013


the following patch was just integrated into master:
commit 73e86a88d223a3c8f0b572c43aa39269df5bff62
Author: Martin Roth <martin.roth at se-eng.com>
Date:   Thu Jan 17 16:28:30 2013 -0700

    F15tn: Fix all warnings, enable warnings as errors
    
    Enable 'all warnings being treated as errors' in thatcher and parmer.
    
    Fixed the following warnings on parmer / thatcher:
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuFeatureLeveling.c:
     In function 'GetGlobalCpuFeatureListAddress':
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuFeatureLeveling.c:291:14:
     warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c:
     In function 'SaveDeviceContext':
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c:245:18:
     warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c:309:16:
     warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/cpuPostInit.c:
     In function 'GetPstateGatherDataAddressAtPost':
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/cpuPostInit.c:235:10:
     warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    
    src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c:
     In function 'MemNInitNBDataTN':
    src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c:353:32:
     warning: assignment from incompatible pointer type [enabled by default]
    src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/TN/mntn.c:363:23:
     warning: assignment from incompatible pointer type [enabled by default]
    
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuFeatureLeveling.c:
     In function 'GetGlobalCpuFeatureListAddress':
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/Feature/cpuFeatureLeveling.c:291:14:
     warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c:
     In function 'SaveDeviceContext':
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c:245:18:
     warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/S3.c:309:16:
     warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    
    In file included from src/northbridge/amd/agesa/family15tn/northbridge.c:37:0:
    src/vendorcode/amd/agesa/f15tn/AGESA.h:1547:0:
     warning: "TOP_MEM" redefined [enabled by default]
    src/include/cpu/amd/mtrr.h:31:0:
     note: this is the location of the previous definition
    src/vendorcode/amd/agesa/f15tn/AGESA.h:1548:0:
     warning: "TOP_MEM2" redefined [enabled by default]
    src/include/cpu/amd/mtrr.h:34:0:
     note: this is the location of the previous definition
    In file included from src/northbridge/amd/agesa/family15tn/northbridge.c:41:0:
    src/vendorcode/amd/agesa/f15tn/Proc/CPU/cpuRegisters.h:378:0:
     warning: "LOCAL_APIC_ADDR" redefined [enabled by default]
    src/include/cpu/x86/lapic_def.h:9:0: note:
     this is the location of the previous definition
    
    In file included from src/mainboard/amd/parmer/BiosCallOuts.h:24:0,
                     from src/mainboard/amd/parmer/mainboard.c:28:
    src/vendorcode/amd/agesa/f15tn/AGESA.h:1547:0:
     warning: "TOP_MEM" redefined [enabled by default]
    src/include/cpu/amd/mtrr.h:31:0:
     note: this is the location of the previous definition
    src/vendorcode/amd/agesa/f15tn/AGESA.h:1548:0:
     warning: "TOP_MEM2" redefined [enabled by default]
    src/include/cpu/amd/mtrr.h:34:0: note:
     this is the location of the previous definition
    
    Change-Id: Iecea28232f1761401cf09f7d2a77d3fbac2f5801
    Signed-off-by: Martin Roth <martin.roth at se-eng.com>
    Reviewed-on: http://review.coreboot.org/2171
    Tested-by: build bot (Jenkins)
    Reviewed-by: Dave Frodin <dave.frodin at se-eng.com>
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>

Reviewed-By: Patrick Georgi <patrick at georgi-clan.de> at Tue Jan 22 12:17:06 2013, giving +2
See http://review.coreboot.org/2171 for details.

-gerrit



More information about the coreboot mailing list