[coreboot] New patch to review for coreboot: 7627550 ASRock E350M1: Disable absent IDE device 0:14.1

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sat Mar 2 11:32:51 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2574

-gerrit

commit 7627550cecf01dd5676133b3dea7145911d28a54
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sat Mar 2 11:21:06 2013 +0100

    ASRock E350M1: Disable absent IDE device 0:14.1
    
    The ASRock E350M1 [1] does not have any IDE connectors, so
    disable that PCI device, which coreboot also does not find.
    
    	coreboot-4.0-3583-gf91c8f2 Sat Mar  2 09:04:55 CET 2013 starting...
    	[…]
    	PCI: 00:14.0 [1002/4385] enabled
    	sb800_enable() PCI: Static device PCI: 00:14.1 not found, disabling it.
    	sb800_enable() hda enabled
    	PCI: 00:14.2 [1002/4383] ops
    
    This PCI device does not even have code for being enabled
    and is just skipped.
    
    	$ more src/southbridge/amd/cimx/sb800/late.c
    	[…]
    	static void sb800_enable(device_t dev)
    	{
    		case (0x14 << 3) | 1: /* 0:14:1 IDE */
    			break;
    	[…]
    	}
    
    [1] http://www.asrock.com/MB/overview.asp?Model=E350M1
    
    Change-Id: I2bbc683b1faccc513bb4c24dce05f3a9892b817b
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/asrock/e350m1/devicetree.cb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/asrock/e350m1/devicetree.cb b/src/mainboard/asrock/e350m1/devicetree.cb
index d47f207..23a218e 100644
--- a/src/mainboard/asrock/e350m1/devicetree.cb
+++ b/src/mainboard/asrock/e350m1/devicetree.cb
@@ -53,7 +53,7 @@ chip northbridge/amd/agesa/family14/root_complex
                                                         device i2c 51 on end
                                                 end
                                         end # SM
-                                        device pci 14.1 on end # IDE    0x439c
+                                        device pci 14.1 off end # IDE   0x439c
                                         device pci 14.2 on end # HDA    0x4383
                                         device pci 14.3 on # LPC        0x439d
 						chip superio/winbond/w83627hf



More information about the coreboot mailing list