[coreboot] Patch merged into coreboot/master: a4b802c ASRock E350M1: mainboard.c: Add declarations for `set_pcie_{, de}reset`

gerrit at coreboot.org gerrit at coreboot.org
Wed Mar 6 22:54:52 CET 2013


the following patch was just integrated into master:
commit a4b802ce866a1f3397f0e93e530bf77e253f60ee
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Wed Mar 6 18:42:02 2013 +0100

    ASRock E350M1: mainboard.c: Add declarations for `set_pcie_{,de}reset`
    
    Since the merg of the ASRock E350M1 port (a649a96e) the compiler
    warns about the following [1].
    
        mainboard.c:35, GNU Compiler 4 (gcc), Priorität: Normal
        no previous prototype for 'set_pcie_reset' [-Wmissing-prototypes]
        mainboard.c:43, GNU Compiler 4 (gcc), Priorität: Normal
        no previous prototype for 'set_pcie_dereset' [-Wmissing-prototypes]
    
    Adding the function prototypes to the beginning of the file as
    done in commit »Persimmon updates for AMD F14 rev C0« (d7a696d0)
    addresses the warning.
    
    [1] http://qa.coreboot.org/job/coreboot-gerrit/4975/warnings13Result/package.-139448264/file.-1544928473/
    [2] http://review.coreboot.org/137
    
    Change-Id: Iad2e62ec37c3a2f749a264974b61ac7c226e9b83
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2590
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Wed Mar  6 19:04:52 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Wed Mar  6 22:54:51 2013, giving +2
See http://review.coreboot.org/2590 for details.

-gerrit



More information about the coreboot mailing list