[coreboot] Patch merged into coreboot/master: a5ddac0 AMD CIMx SB800 boards: platform_cfg.h: Integrate Kconfig SATA Mode choice

gerrit at coreboot.org gerrit at coreboot.org
Fri Mar 8 22:25:13 CET 2013


the following patch was just integrated into master:
commit a5ddac02f40e2ebe5606ea65e5c22c63baa2c1c9
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Mar 3 10:56:15 2013 +0100

    AMD CIMx SB800 boards: platform_cfg.h: Integrate Kconfig SATA Mode choice
    
    Currently for Advansus A785E-I, ASRock E350M1 and ASUS M5A88-V
    despite what is chosen in Kconfig »Chipset« menu item,
    
        $ more .config
        […]
        # CONFIG_ENABLE_IDE_COMBINED_MODE is not set
        CONFIG_IDE_COMBINED_MODE=0x1
        # CONFIG_SB800_SATA_IDE is not set
        CONFIG_SB800_SATA_AHCI=y
        # CONFIG_SB800_SATA_RAID is not set
        CONFIG_SB800_SATA_MODE=0x2
        […]
    
    the SATA controller is put into IDE mode.
    
        $ lspci -nn | grep SATA
        00:11.0 SATA controller [0106]: Advanced Micro Devices [AMD] nee ATI SB7x0/SB8x0/SB9x0 SATA Controller [IDE mode] [1002:4390] (rev 40)
    
    Commit »sb800: Add sata ahci/raid mode kconfig option«
    (d4a0e7d0) [1] added the options above to configure the mode
    using Kconfig and some SB800 boards were adapted already. For
    example commit »persimmon: sb800 sata mode configure update«
    (1386fa74) [2] did so for AMD Persimmon.
    
    Doing the same by assigning the Kconfig variable to the value in
    `platform_cfg.h` integrates this with the three remaining boards
    listed above.
    
    The patch is successfully tested with the ASRock E350M1.
    
        $ lspci -nn | grep SATA
        00:11.0 SATA controller [0106]: Advanced Micro Devices [AMD] nee ATI SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode] [1002:4391] (rev 40)
    
    [1] http://review.coreboot.org/225
    [2] http://review.coreboot.org/227
    
    Change-Id: I227257e2c8f04f18c27ff00fe62d42e372de67e4
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2610
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martin.roth at se-eng.com>

Build-Tested: build bot (Jenkins) at Fri Mar  8 15:54:28 2013, giving +1
Reviewed-By: Martin Roth <martin.roth at se-eng.com> at Fri Mar  8 17:38:51 2013, giving +2
See http://review.coreboot.org/2610 for details.

-gerrit



More information about the coreboot mailing list