[coreboot] Patch set updated for coreboot: 05aa44e lynxpoint: remove DEBUG_PERIODIC_SMIS
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Tue Mar 19 20:27:43 CET 2013
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2814
-gerrit
commit 05aa44e79a377c2dfc825b010d2072ee51a6f848
Author: Duncan Laurie <dlaurie at chromium.org>
Date: Fri Mar 8 16:06:06 2013 -0800
lynxpoint: remove DEBUG_PERIODIC_SMIS
This was put in for debugging and experimentation on i945
and has been copied around since. Drop it from lynxpoint.
Change-Id: I0b53f4e1362cd3ce703625ef2b4988139c48b989
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
src/southbridge/intel/lynxpoint/lpc.c | 6 ------
src/southbridge/intel/lynxpoint/pch.h | 1 -
src/southbridge/intel/lynxpoint/smi.c | 6 ------
3 files changed, 13 deletions(-)
diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c
index eaf926c..89cf9e7 100644
--- a/src/southbridge/intel/lynxpoint/lpc.c
+++ b/src/southbridge/intel/lynxpoint/lpc.c
@@ -255,12 +255,6 @@ static void pch_power_options(device_t dev)
reg16 = pci_read_config16(dev, GEN_PMCON_1);
reg16 &= ~(3 << 0); // SMI# rate 1 minute
reg16 &= ~(1 << 10); // Disable BIOS_PCI_EXP_EN for native PME
-#if DEBUG_PERIODIC_SMIS
- /* Set DEBUG_PERIODIC_SMIS in pch.h to debug using
- * periodic SMIs.
- */
- reg16 |= (3 << 0); // Periodic SMI every 8s
-#endif
pci_write_config16(dev, GEN_PMCON_1, reg16);
// Set the board's GPI routing.
diff --git a/src/southbridge/intel/lynxpoint/pch.h b/src/southbridge/intel/lynxpoint/pch.h
index 0f20a83..f2953d2 100644
--- a/src/southbridge/intel/lynxpoint/pch.h
+++ b/src/southbridge/intel/lynxpoint/pch.h
@@ -79,7 +79,6 @@
#define DEFAULT_RCBA 0xfed1c000
#ifndef __ACPI__
-#define DEBUG_PERIODIC_SMIS 0
#if defined (__SMM__) && !defined(__ASSEMBLER__)
void intel_pch_finalize_smm(void);
diff --git a/src/southbridge/intel/lynxpoint/smi.c b/src/southbridge/intel/lynxpoint/smi.c
index 80dea2c..a3354b8 100644
--- a/src/southbridge/intel/lynxpoint/smi.c
+++ b/src/southbridge/intel/lynxpoint/smi.c
@@ -281,12 +281,6 @@ void southbridge_smm_init(void)
#endif
smi_en |= TCO_EN;
smi_en |= APMC_EN;
-#if DEBUG_PERIODIC_SMIS
- /* Set DEBUG_PERIODIC_SMIS in pch.h to debug using
- * periodic SMIs.
- */
- smi_en |= PERIODIC_EN;
-#endif
smi_en |= SLP_SMI_EN;
#if 0
smi_en |= BIOS_EN;
More information about the coreboot
mailing list