[coreboot] Adding checks for non-ASCII filenames (was: [Gerrit] gitconfig: Add sample checks shipped by git to pre-commit hook)

[Paul Menzel]

Dear coreboot folks,


Am Donnerstag, den 30.05.2013, 01:57 +0200 schrieb gerrit code review:

From <http://review.coreboot.org/3336>:

> Change subject: gitconfig: Add sample checks shipped by git to pre-commit hook
> ......................................................................
> 
> 
> Patch Set 2: Code-Review-2
> 
> It does not make sense to have a hook that checks a tree-wide policy
> and then allow that policy to be disabled by configuration. Either we
> decide on the filename policy or we do not need the hook.

as non-ASCII characters are not allowed in our source [1], I assume they
are also not allowed in file names.

The sample pre-commit hook shipped by git has a check for non-ASCII file
names, which can be disabled by a config option.

Are there any circumstances where non-ASCII characters might be needed?
If not, Peter is right and the option can be removed from the script,
which I would do then.


Thanks,

Paul


[1] http://review.coreboot.org/2604
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20130530/d423a4e3/attachment.sig>