[coreboot] Endian issue for libpayload options
Sean McNeil
seanmcneil3 at gmail.com
Thu May 29 10:57:10 CEST 2014
options are broken for x86 because it is assuming big endian. A quick
patch to make it work:
diff --git a/payloads/libpayload/drivers/options.c
b/payloads/libpayload/drivers
index 70c2b17..a7a5d82 100644
--- a/payloads/libpayload/drivers/options.c
+++ b/payloads/libpayload/drivers/options.c
@@ -69,7 +69,7 @@ int options_checksum_valid(const struct nvram_accessor
*nvram)
checksum += nvram->read(i);
}
- checksum_old = ((nvram->read(checksum_location)<<8) |
nvram->read(checks
+ checksum_old = ((nvram->read(checksum_location+1)<<8) |
nvram->read(chec
return (checksum_old == checksum);
}
Maybe a union and assigning each byte is the correct approach?
Cheers,
Sean
More information about the coreboot
mailing list