[coreboot] Mistery of the function: static void enable_rom_caching(void)

[Zoran Stojsavljevic]

Hello community,

I was/got again today in Coreboot directory
src/soc/intel/braswell/bootblock/bootblock.c looking at static void
enable_rom_caching(void).

Then, since Paul Menzel have announcement ([ANNOUNCEMENT] Support for Intel
Kaby Lake), I went to look into
src/soc/intel/skylake/bootblock/bootblock.c, but I did not find this
function. Kaby Lake patches do not support this function as well.

Then I did the following on my WIN 10 (using VMware workstation 12) VM
Fedora 24:

[zoran at localhost intel]$ pwd
/home/zoran/projects/coreboot/coreboot/src/soc/intel
[zoran at localhost intel]$ git describe
4.4-1038-gdd65ef8
[zoran at localhost intel]$ ls -al
total 48
drwxrwxr-x. 12 4096 Aug  1 10:02 .
drwxrwxr-x. 14 4096 Aug  1 10:02 ..
drwxrwxr-x.  5 4096 Aug  1 10:02 apollolake
drwxrwxr-x.  6 4096 Aug  1 10:02 baytrail
drwxrwxr-x.  6 4096 Aug  1 10:02 braswell
drwxrwxr-x.  6 4096 Aug  1 10:02 broadwell
drwxrwxr-x.  3 4096 Aug  1 10:02 common
drwxrwxr-x.  7 4096 Aug  1 10:02 fsp_baytrail
drwxrwxr-x.  7 4096 Aug  1 10:02 fsp_broadwell_de
drwxrwxr-x.  5 4096 Aug  1 10:02 quark
drwxrwxr-x.  3 4096 Aug  1 10:02 sch
drwxrwxr-x.  7 4096 Aug  1 10:02 skylake
[zoran at localhost intel]$ grep -r enable_rom *
baytrail/bootblock/bootblock.c:static void enable_rom_caching(void)
baytrail/bootblock/bootblock.c: enable_rom_caching();
braswell/bootblock/bootblock.c:static void enable_rom_caching(void)
braswell/bootblock/bootblock.c: enable_rom_caching();
broadwell/bootblock/cpu.c:static void enable_rom_caching(void)
broadwell/bootblock/cpu.c: enable_rom_caching();
fsp_baytrail/bootblock/bootblock.c:static void enable_rom_caching(void)
fsp_baytrail/bootblock/bootblock.c: enable_rom_caching();
[zoran at localhost intel]$

We see here that from skylake (also does not exists in apollolake) this
function is dropped.

Any logical explanation for this mismatch?

Thank you,
Zoran
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20160808/9c0fbda0/attachment.html>