[coreboot] Building 4.5 from release sources

[Aaron Durbin]

On Thu, Jan 5, 2017 at 1:45 PM, Peter Stuge <peter at stuge.se> wrote:
> Trammell Hudson wrote:
>> When I build coreboot 4.5 from the release sources it is necessary
>> to download the coreboot-blobs-4.5.tar.xz file and it looks like there
>> might be a dependency now on the 3rdparty/vboot tree as well since
>> cbfs.h includes vb2_api.h:
>>
>> https://github.com/coreboot/coreboot/blob/master/src/commonlib/include/commonlib/cbfs.h#L21
>
> This seems like a bug to me. I think the vboot header should either
> be conditionally included according to configuration, or if it's an
> ABI then I would suggest to keep a local copy. I assume the ABI is
> versioned, so back+forward compatibility should be no problem.

Whether or not that include is removed from that file doesn't matter.
cbfstool uses vb2 for the hashing routines internally -- as well as
coreboot proper. This was discussed around a month ago on #coreboot,
iirc. I don't recall with whom aside from Damien, but people were
going to look into providing a crypto interface that can be
implemented for hashing, etc. This CL spawned that discussion:
https://review.coreboot.org/#/c/17469/ However, I haven't seen that
work at all yet.

I tried removing that API a while back, but I can't find that CL. I'm
not sure why. I think Zaolin wanted that API. Here's a CL to remove it
that will fail to build because of what I described:
https://review.coreboot.org/18045


>
>
> //Peter
>
> --
> coreboot mailing list: coreboot at coreboot.org
> https://www.coreboot.org/mailman/listinfo/coreboot