[flashrom] [PATCH] Fix another SB600 SPI corner case

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Mon Aug 10 03:33:23 CEST 2009


On 10.08.2009 02:56, Carl-Daniel Hailfinger wrote:
> SB600 SPI has an off-by-one error during read, and that hardware issue
> is not documented anywhere yet. r661 tried to work around this, but the
> fix had unpleasant side effects. The new workaround only triggers if
> readcnt is nonzero, eliminating all possible interactions with
> write-only commands.
>
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>   

Turns out that the bug we were seeing is totally unrelated. Still, this
patch needs to be checked on real hardware with a logic analyzer. A
simple "looks good" ack won't do, sorry.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list