[flashrom] [PATCH] fix MSR code in flashrom

Stefan Reinauer stepan at coresystems.de
Tue Aug 11 15:59:49 CEST 2009


On 8/11/09 3:43 PM, Carl-Daniel Hailfinger wrote:
> On 11.08.2009 15:00, Stefan Reinauer wrote:
>   
>> See patch... With this flashrom won't try to open /dev/cpu/x/msr on
>> non-linux OSes...
>>
>> Fix up MSR handling in flashrom to support more OSes than Linux. 
>>
>> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
>>   
>>     
> I'm not totally happy with the abstraction and think getting MSR access
> should be part of getting IO permissions, but this is a good step forward.
>   

I considered that. BUT: Why make code run every time, if it's only
needed on 1% or less of the machines.


Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866





More information about the flashrom mailing list