[flashrom] [PATCH] Add support for RayeR SPIPGM hardware.

[Carl-Daniel Hailfinger]

Hi Martin,

On 01.07.2010 02:28, RayeR wrote:
> sorry for delay, still busy...

No problem. Thanks for testing.


> Today I tested flashrom on my PC (P31/ICH7) with my SPI prog &
> Macronix MX25L1605 chip.
> It seems to work OK but noticably slower than my SPIPGM. E.g. reading
> is guess 2x longer but

Yes, all operations are unoptimized. I just wanted to get them working.

> erase was extremely long ~3min vs 10sec. Well I use chip erase
> instruction to do it fastest
> as possible and flashrom probably erase sector by sector...

flashrom uses sector erase, and reads the sector afterwards to make sure
that the erase worked correctly. This means flashrom will take the time
it needs to erase all sectors (~10-30 seconds maybe), and in addition it
needs the time to read the complete chip.


> Also it would be good to add
> some progress indicator (it's stupid when looking at "wait..." message
> several minutes and
> tempting to hit ctrl-c/reset :)

Yes, we're working on a progress indicator.


> --------------------------------------------------
>
> flashrom v0.9.2-r1039 on MS-DOS 7 (i686), built with libpci 3.1.5, GCC
> 4.3.2, little endian
> flashrom is free software, get the source code at http://www.flashrom.org
>
> Calibrating delay loop... OS timer resolution is 50000 usecs, 3178M
> loops per second, 10 myus = 0 us, 100 myus = 0 us, 1000 myus = 0 us,
> 10000 myus = 0 us, 200000 myus = 220000 us, OK.
> Initializing rayer_bitbang_spi programmer
> Using port 0x378 as I/O base for parallel port access.
> ...
> Probing for Macronix MX25L1605, 2048 KB: probe_spi_rdid_generic: id1
> 0xc2, id2 0x2015
> Chip status register is 00
> Chip status register: Status Register Write Disable (SRWD) is not set
> Chip status register: Bit 6 is not set
> Chip status register: Bit 5 / Block Protect 3 (BP3) is not set
> Chip status register: Bit 4 / Block Protect 2 (BP2) is not set
> Chip status register: Bit 3 / Block Protect 1 (BP1) is not set
> Chip status register: Bit 2 / Block Protect 0 (BP0) is not set
> Chip status register: Write Enable Latch (WEL) is not set
> Chip status register: Write In Progress (WIP/BUSY) is not set
> Found chip "Macronix MX25L1605" (2048 KB, SPI) at physical address
> 0xffe00000.
> ...
> No operations were specified.

The log looks good. Since flashrom works for you, I'd like to commit
this code, and work on improving the speed later. I think a factor of 2
speedup is possible.
Can I have an "Acked-by: Your Name <your at email>" from you to go ahead
and commit? Thanks.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/