[flashrom] [PATCH] Convert SPI chips to partial write

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Wed Jul 14 18:24:10 CEST 2010


On 14.07.2010 18:15, Michael Karcher wrote:
> Am Mittwoch, den 14.07.2010, 16:14 +0200 schrieb Carl-Daniel Hailfinger:
>
>   
>> Since we're only handling a very special case
>> (round_up_to_next_multiple_of_power_of_two_granularity) and use it only
>> one time anyway, it doesn't really make sense to provide a separate
>> function for this. Killed as per IRC discussion.
>>     
> And the single line rewritten as per further IRC discussion. IRC
> discussion result:
>
>     lenhere = min(len, (start | 0xff) - start + 1);
>
>   
>>> If you use the bitwise round-up here:
>>> Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
>>>       
>
> Still stands.
> Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
>   

Thanks, committed in r1080.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list