[flashrom] [PATCH] Safety checks for SPI bitbang init

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Jul 18 16:43:56 CEST 2010


On 18.07.2010 16:27, Michael Karcher wrote:
> Am Sonntag, den 18.07.2010, 13:20 +0200 schrieb Carl-Daniel Hailfinger:
>   
>> Check during SPI bitbang init that SPI bitbang master configuration is
>> correct.
>>     
> As clarified on IRC, this is meant as tool for people adding new bitbang
> adapters. As this it is fine. One could think about not building the
> check if "CONFIG_RELEASE=yes".
>   

There are quite a few safety checks we could kill in a release build...


>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>     
> Acked-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>
>   

Thanks, committed in r1092.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list