[coreboot-gerrit] New patch to review for coreboot: 1991f39 UCB RISCV: Switch to DYNAMIC_CBMEM

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Mon Dec 1 19:46:20 CET 2014


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7619

-gerrit

commit 1991f399f8a5ca617f58fd7f3cf30709a7137631
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Dec 1 20:35:43 2014 +0200

    UCB RISCV: Switch to DYNAMIC_CBMEM
    
    Change-Id: Iaaf68fd19f7b9a5b6849fffde3a9c68cb7862367
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/arch/riscv/tables.c   | 20 --------------------
 src/soc/ucb/riscv/Kconfig |  1 +
 2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/src/arch/riscv/tables.c b/src/arch/riscv/tables.c
index 0265949..6300f7b 100644
--- a/src/arch/riscv/tables.c
+++ b/src/arch/riscv/tables.c
@@ -29,15 +29,6 @@
 
 #define MAX_COREBOOT_TABLE_SIZE (8 * 1024)
 
-#if ! IS_ENABLED(CONFIG_DYNAMIC_CBMEM)
-/*
- * TODO: "High" tables are a convention used on x86. Maybe we can
- * clean up that naming at some point.
- */
-uint64_t high_tables_base = 0;
-uint64_t high_tables_size;
-#endif
-
 void cbmem_arch_init(void)
 {
 }
@@ -47,14 +38,6 @@ static struct lb_memory *wtf_write_tables(void)
 {
 	unsigned long table_pointer, new_table_pointer;
 
-#if ! IS_ENABLED(CONFIG_DYNAMIC_CBMEM)
-	if (!high_tables_base) {
-		printk(BIOS_ERR, "ERROR: high_tables_base is not set.\n");
-	}
-
-	printk(BIOS_DEBUG, "high_tables_base: %llx.\n", high_tables_base);
-#endif
-
 	post_code(0x9d);
 
 	table_pointer = (unsigned long)cbmem_add(CBMEM_ID_CBTABLE,
@@ -91,6 +74,3 @@ void write_tables(void)
 void cbmem_fail_resume(void)
 {
 }
-void get_cbmem_table(uint64_t *base, uint64_t *size)
-{
-}
diff --git a/src/soc/ucb/riscv/Kconfig b/src/soc/ucb/riscv/Kconfig
index d1e4ba7..be4a675 100644
--- a/src/soc/ucb/riscv/Kconfig
+++ b/src/soc/ucb/riscv/Kconfig
@@ -3,6 +3,7 @@ config SOC_UCB_RISCV
 	select ARCH_BOOTBLOCK_RISCV
 	select ARCH_ROMSTAGE_RISCV
 	select ARCH_RAMSTAGE_RISCV
+	select DYNAMIC_CBMEM
 	bool
 	default n
 



More information about the coreboot-gerrit mailing list