[coreboot-gerrit] Patch merged into coreboot/master: 5a45c95 rambi: Add ACPI table support for I2C devices

gerrit at coreboot.org gerrit at coreboot.org
Thu May 15 05:05:34 CEST 2014


the following patch was just integrated into master:
commit 5a45c9529a24a1be0a288fac2dab45b24e50c272
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon Jan 13 10:15:12 2014 -0800

    rambi: Add ACPI table support for I2C devices
    
    In order to support probing I2C devices when the controller is
    in ACPI mode the mainboard needs to decalre them in the proper
    scope with the address/interrupt information.  The touchpad devices
    are ATML0000/ELAN0000 and the touchscreen is ATML0001 so they can
    be distinguished in userland scripts based on ID.  There is also
    a special "ISTP" node that indicates whether the devices is a
    touchpad (=1) or touchscreen (=0) in case this is useful to drivers.
    
    These names may not be final but they are a starting point and can
    be easily changed.
    
    Atmel devices also have a bootloader mode which needs to be
    declared as a separate device.  Unfortunately it does not work as
    expected to have multiple I2cSerialBus() resources declared in a
    single device and have it select properly, even with the use of
    StartDependentFn(), so bootloader devices are declared separately.
    
    The original devices are left in \_SB scope and are only enabled
    if the I2C controllers are in PCI mode.  The new devices are only
    enabled if the I2C controllers are in ACPI mode.
    
    BUG=chrome-os-partner:24380
    BRANCH=baytrail
    TEST=manual
    
    1) Ensure there is no change in functionality by default and that
    the devices are still probed by chromeos_laptop in the kernel.
    2) Enable lpss_acpi_mode=1 in devicetree.cb and kernel changes to
    add _HID entries for devices in appropriate drivers.  Ensure that
    the devices are probed successfully.  Further changes are needed
    to the chromeos-touch-firmware scripts to load config and update
    firmware based on the new ACPI _HID entries.
    3) Put touchpad in bootloader mode (by flashing bad firmware) and
    ensure that it is detected at address 0x25 and the firmware is
    able to be updated.
    
    Change-Id: I5b9b47ddc94474a677497271e963f62cb09438e0
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/182259
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/5045
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>


See http://review.coreboot.org/5045 for details.

-gerrit



More information about the coreboot-gerrit mailing list