[coreboot-gerrit] New patch to review for coreboot: veyron_rialto: remove spurious GPIO assignments

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Thu Aug 27 15:39:31 CEST 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11400

-gerrit

commit dced1a3e6bbbd7b824a5998591e532173f502833
Author: Alexandru M Stan <amstan at chromium.org>
Date:   Thu Aug 20 11:45:26 2015 -0700

    veyron_rialto: remove spurious GPIO assignments
    
    GPIO(0, B, 3) and GPIO(7, C, 5) are not actually connected,
    GPIO(0, B, 4) is named differently.
    
    BUG=chrome-os-partner:43031
    TEST=Rialto should still boot just fine, USB should still work
    BRANCH=master
    
    Change-Id: I11879385de6e9b57ac28bcae699333beb5a0d64c
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Original-Commit-Id: a66bf1fd73ff8d15d4ec1a8f3602465941285c32
    Original-Change-Id: Ib7d2baa6ed1ab38db786eb4d5e77316ad72cbfd4
    Original-Signed-off-by: Alexandru M Stan <amstan at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/294713
    Original-Reviewed-by: David Hendricks <dhendrix at chromium.org>
---
 src/mainboard/google/veyron_rialto/mainboard.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/mainboard/google/veyron_rialto/mainboard.c b/src/mainboard/google/veyron_rialto/mainboard.c
index 4dba666..c2dde19 100644
--- a/src/mainboard/google/veyron_rialto/mainboard.c
+++ b/src/mainboard/google/veyron_rialto/mainboard.c
@@ -43,9 +43,7 @@
 
 static void configure_usb(void)
 {
-	gpio_output(GPIO(0, B, 3), 1);			/* HOST1_PWR_EN */
-	gpio_output(GPIO(0, B, 4), 1);			/* USBOTG_PWREN_H */
-	gpio_output(GPIO(7, C, 5), 1);			/* 5V_DRV */
+	gpio_output(GPIO(0, B, 4), 1);			/* USB2_PWR_EN */
 }
 
 static void configure_emmc(void)



More information about the coreboot-gerrit mailing list