[coreboot-gerrit] Patch merged into coreboot/master: intel/braswell: allow dirty cache line evictions for SMRAM to stick

gerrit at coreboot.org gerrit at coreboot.org
Sat Aug 29 09:10:58 CEST 2015


the following patch was just integrated into master:
commit fd016a44bb5221c0b47dc9e1b922a5290c16526c
Author: Chiranjeevi Rapolu <chiranjeevi.rapolu at intel.com>
Date:   Tue Aug 11 14:09:46 2015 -0700

    intel/braswell: allow dirty cache line evictions for SMRAM to stick
    
    The BUNIT controls the policy for read/write access to physical
    memory. For the SMRAM range the policy was not allowing dirty
    evictions to the SMRAM when the core causing the eviction was not
    in SMM mode. This could happen when the SMM handler dirtied a line
    and then RSM'd back into non-SMM mode. The cache line was dirtied
    while in SMM mode, but when that particular cache line was evicted
    it would be silently dropped. Fix this by allowing the BUNIT to honor
    writes to the SMRAM range while the evicting core is not in SMM mode.
    The core SMRR msr provides the mechanism for disallowing general access
    to the SMRAM region while it is not in SMM mode.
    
    BUG=chrome-os-partner:43091
    BRANCH=None
    TEST=Run suspend_stress_test and ensure there is no hang SMI handler
    on suspend-path.
    Signed-off-by: Chiranjeevi Rapolu <chiranjeevi.rapolu at intel.com>
    
    Change-Id: Ie794aa3afd54b5e21d0d59a2a7388d507f233537
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Original-Commit-Id: 9c481ab339b4e5ab063e2c32b1f0a48b521142b2
    Original-Change-Id: I3e7d41c794c6168eb2ad4eb047675bdb1728f72f
    Original-Reviewed-on: https://chromium-review.googlesource.com/292890
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Original-Commit-Queue: Hannah Williams <hannah.williams at intel.com>
    Original-Tested-by: Hannah Williams <hannah.williams at intel.com>
    Reviewed-on: http://review.coreboot.org/11412
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See http://review.coreboot.org/11412 for details.

-gerrit



More information about the coreboot-gerrit mailing list