[coreboot-gerrit] New patch to review for coreboot: drivers/xgi/common: Fix XGI_SetGroup2

[Stefan Reinauer (stefan.reinauer@coreboot.org)]

Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12774

-gerrit

commit 1206675b7543c232d83b5c09b81c853480d806e0
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Thu Dec 17 13:03:11 2015 -0800

    drivers/xgi/common: Fix XGI_SetGroup2
    
    This code looks like it was created from a disassembly of some
    other driver. Attempt to fix it, without hardware or documentation.
    
    CID 142909: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
    
    Change-Id: I9b9cadf2acdba73913aad6bbe0d14ad64a652915
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 src/drivers/xgi/common/vb_setmode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/drivers/xgi/common/vb_setmode.c b/src/drivers/xgi/common/vb_setmode.c
index 91e4929..0143076 100644
--- a/src/drivers/xgi/common/vb_setmode.c
+++ b/src/drivers/xgi/common/vb_setmode.c
@@ -3616,7 +3616,7 @@ static void XGI_SetGroup2(unsigned short ModeNo, unsigned short ModeIdIndex,
 				| (tempax & 0x00FF));
 		temp = (tempax & 0xFF00) >> 8;
 	} else {
-		temp = (tempax & 0x00FF) >> 8;
+		temp = (tempax & 0x00FF);
 	}
 
 	xgifb_reg_set(pVBInfo->Part2Port, 0x44, temp);