[coreboot-gerrit] New patch to review for coreboot: x86: Fix order of fields in SMBIOS table type 1

Ben Gardner (gardner.ben@gmail.com) gerrit at coreboot.org
Thu Dec 17 23:30:24 CET 2015


Ben Gardner (gardner.ben at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12775

-gerrit

commit 5a39fa54073a3357a6b9840d65df7740ddcfd93c
Author: Ben Gardner <gardner.ben at gmail.com>
Date:   Thu Dec 17 16:25:43 2015 -0600

    x86: Fix order of fields in SMBIOS table type 1
    
    According to the SMBIOS specification, the version field is before the
    serial_number field.
    
    Change-Id: I2890a22185fcde4013cabdf95cc0e43c97e125f2
    Signed-off-by: Ben Gardner <gardner.ben at gmail.com>
---
 src/arch/x86/smbios.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c
index 305ba40..4396f3d 100644
--- a/src/arch/x86/smbios.c
+++ b/src/arch/x86/smbios.c
@@ -342,8 +342,8 @@ static int smbios_write_type1(unsigned long *current, int handle)
 	t->length = len - 2;
 	t->manufacturer = smbios_add_string(t->eos, smbios_mainboard_manufacturer());
 	t->product_name = smbios_add_string(t->eos, smbios_mainboard_product_name());
-	t->serial_number = smbios_add_string(t->eos, smbios_mainboard_serial_number());
 	t->version = smbios_add_string(t->eos, smbios_mainboard_version());
+	t->serial_number = smbios_add_string(t->eos, smbios_mainboard_serial_number());
 #ifdef CONFIG_MAINBOARD_FAMILY
 	t->family = smbios_add_string(t->eos, smbios_mainboard_family());
 #endif



More information about the coreboot-gerrit mailing list