[coreboot-gerrit] Patch set updated for coreboot: 37ce0a3 amd/amdfam10: Fix invalid transition latency in PowerNow! _PSS objects

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Sat Feb 7 19:54:02 CET 2015


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8376

-gerrit

commit 37ce0a32c7342bead7bfa36d5f5350dbc768edf1
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Fri Feb 6 16:07:53 2015 -0600

    amd/amdfam10: Fix invalid transition latency in PowerNow! _PSS objects
    
    Fix a mistake that led to an invalid 0ms latency in the automatically
    generated PowerNow! ACPI _PSS objects.
    
    TEST: Booted FreeBSD and Linux and verified correct latency values.
    
    Found-by: Coverity Scan
    Change-Id: I03cecab694708136dc555ca2af7ee9a0bf9be5af
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/cpu/amd/model_10xxx/powernow_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cpu/amd/model_10xxx/powernow_acpi.c b/src/cpu/amd/model_10xxx/powernow_acpi.c
index e4e0289..d08f9f9 100644
--- a/src/cpu/amd/model_10xxx/powernow_acpi.c
+++ b/src/cpu/amd/model_10xxx/powernow_acpi.c
@@ -212,7 +212,7 @@ static void pstates_algorithm(u32 pcontrol_blk, u8 plen, u8 onlyBSP)
 		power_step_up = (dtemp & 0xf000000) >> 24;
 		power_step_down = (dtemp & 0xf00000) >> 20;
 		dtemp = pci_read_config32(dev_find_slot(0, PCI_DEVFN(0x18, 3)), 0xA0);
-		pll_lock_time = (pll_lock_time & 0x3800) >> 11;
+		pll_lock_time = (dtemp & 0x3800) >> 11;
 		if (all_enabled_cores_have_same_cpufid)
 			core_latency = ((12 * power_step_down) + power_step_up) / 1000;
 		else



More information about the coreboot-gerrit mailing list