[coreboot-gerrit] Patch set updated for coreboot: 7d73cb5 amd/sb600: Fix NULL test after use issue
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Feb 23 22:07:58 CET 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8513
-gerrit
commit 7d73cb5227d483133b00c1be6ed13d151076db1e
Author: Patrick Georgi <patrick at georgi-clan.de>
Date: Sun Feb 22 17:54:18 2015 +0100
amd/sb600: Fix NULL test after use issue
Change-Id: Icecbcc1dee837ecfe0dd52bade3b83fdcdd15bad
Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
Found-by: Coverity Scan
---
src/southbridge/amd/sb600/hda.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/southbridge/amd/sb600/hda.c b/src/southbridge/amd/sb600/hda.c
index de7a319..9706289 100644
--- a/src/southbridge/amd/sb600/hda.c
+++ b/src/southbridge/amd/sb600/hda.c
@@ -157,11 +157,11 @@ static u32 find_verb(u32 viddid, u32 ** verb)
device_t azalia_dev = dev_find_slot(0, PCI_DEVFN(0x14, 2));
struct southbridge_amd_sb600_config *cfg =
(struct southbridge_amd_sb600_config *)azalia_dev->chip_info;
+ if (!cfg)
+ return 0;
printk(BIOS_DEBUG, "Dev=%s\n", dev_path(azalia_dev));
printk(BIOS_DEBUG, "Default viddid=%x\n", cfg->hda_viddid);
printk(BIOS_DEBUG, "Reading viddid=%x\n", viddid);
- if (!cfg)
- return 0;
if (viddid != cfg->hda_viddid)
return 0;
*verb = (u32 *) cim_verb_data;
More information about the coreboot-gerrit
mailing list