[coreboot-gerrit] Patch set updated for coreboot: 4d19b5a libpayload: Don't try to free individual xhci device slots
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Mon Feb 23 22:08:05 CET 2015
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8515
-gerrit
commit 4d19b5af364dacab44d2cd89ce439bd8221141f1
Author: Patrick Georgi <patrick at georgi-clan.de>
Date: Sun Feb 22 22:50:32 2015 +0100
libpayload: Don't try to free individual xhci device slots
`di` points to a single item in xhci->dev[], which is malloc'd
collectively. Trying to free() leads to pain.
Change-Id: Ibd99eda905d43cbf2d2c111dfd0186ed6b119329
Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
Found-by: Coverity Scan
---
payloads/libpayload/drivers/usb/xhci_devconf.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/payloads/libpayload/drivers/usb/xhci_devconf.c b/payloads/libpayload/drivers/usb/xhci_devconf.c
index 5699499..012f610 100644
--- a/payloads/libpayload/drivers/usb/xhci_devconf.c
+++ b/payloads/libpayload/drivers/usb/xhci_devconf.c
@@ -218,7 +218,6 @@ _free_return:
free(tr);
if (di)
free(di->ctx.raw);
- free((void *)di);
_free_ic_return:
if (ic)
free(ic->raw);
More information about the coreboot-gerrit
mailing list