[coreboot-gerrit] Patch set updated for coreboot: 957465c intel/broadwell: free local heap object

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Feb 23 22:08:10 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/8511

-gerrit

commit 957465c6c8b278772bbfafd27bbd8e7e1895081e
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Sun Feb 22 16:51:23 2015 +0100

    intel/broadwell: free local heap object
    
    No real harm done (thanks to our free() implementation),
    but let's do it right.
    
    Change-Id: Ib98d28aabc043dff5c288728c33490a79f09f35a
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
    Found-by: Coverity Scan
---
 src/soc/intel/broadwell/me.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/soc/intel/broadwell/me.c b/src/soc/intel/broadwell/me.c
index fd28cfe..9ec1d44 100644
--- a/src/soc/intel/broadwell/me.c
+++ b/src/soc/intel/broadwell/me.c
@@ -998,6 +998,7 @@ static int intel_me_read_mbp(me_bios_payload *mbp_data, device_t dev)
 	}
 	#undef ASSIGN_FIELD_PTR
 
+	free(mbp);
 	return 0;
 
 mbp_failure:



More information about the coreboot-gerrit mailing list