[coreboot-gerrit] New patch to review for coreboot: nvramtool: Print computed and stored checksum in case of mismatch.

Denis Carikli (GNUtoo@no-log.org) gerrit at coreboot.org
Tue Feb 23 01:30:53 CET 2016


Denis Carikli (GNUtoo at no-log.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13770

-gerrit

commit ed460dd687f69d0d3fe9290f92714eea27e68169
Author: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
Date:   Sat Feb 20 18:49:13 2016 +0100

    nvramtool: Print computed and stored checksum in case of mismatch.
    
    This is to make it easier to fix checksum issues. Example:
      # nvramtool -a
      [...]
      nvramtool: Warning: Coreboot CMOS checksum is bad.
      Computed checksum: 0xfa. Stored checksum: 0x0
      # nvramtool -c 0xfa
    
    Change-Id: Ifacb68b5693afbdfcb521acd6937e270ead85186
    Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo at no-log.org>
---
 util/nvramtool/cmos_ops.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/util/nvramtool/cmos_ops.c b/util/nvramtool/cmos_ops.c
index 8873633..6f616a0 100644
--- a/util/nvramtool/cmos_ops.c
+++ b/util/nvramtool/cmos_ops.c
@@ -229,6 +229,8 @@ void cmos_checksum_verify(void)
 	if (computed != actual) {
 		fprintf(stderr, "%s: Warning: Coreboot CMOS checksum is bad.\n",
 			prog_name);
+		fprintf(stderr, "Computed checksum: 0x%x. Stored checksum: 0x%x\n",
+			computed, actual);
 		exit(1);
 	}
 }



More information about the coreboot-gerrit mailing list