pirq checking

ron minnich rminnich at lanl.gov
Thu Jun 3 10:01:01 CEST 2004

On Thu, 3 Jun 2004, Stefan Reinauer wrote:

> the current pirq code defines intel_irq_routing_table as const, thus
> making it potentially readonly. 

should be const due to execute-in-place issues. 

> OTOH the code in arch/i386/boot/pirq_routing.c tries to correct the 
> checksum and size entries in that table.

that's my fault I bet. 

> I think that table should not be declared const, especially since we
> might want to create it dynamically later on.

no, leave const unless we ALWAYS copy to memory and then work with it.


More information about the coreboot mailing list