[LinuxBIOS] DIMM Page Size
Stefan Reinauer
stepan at coresystems.de
Fri Jul 13 12:38:02 CEST 2007
* Peter Stuge <peter at stuge.se> [070713 12:16]:
> On Fri, Jul 13, 2007 at 01:44:52AM -0400, Joseph Smith wrote:
> > /* convert to Kilobytes */
> > dra = ((page_size / 8) >> 10);
>
> Please don't use bit shifting for multiplication and division.
I think this is a bad dogma. Using shifts for mul/div is pretty obvious
to understand and almost courteous.
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
More information about the coreboot
mailing list