[LinuxBIOS] [PATCH] v3: fix compilation due to multiple definitions of printk

Stefan Reinauer stepan at coresystems.de
Fri Nov 23 00:04:44 CET 2007

* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [071122 21:44]:
> The introduction of the _SHARED macros had one flaw: If multiple files
> had _SHARED defined during compilation, each of them would contain an
> assignment of stage0_printk to *printk. During linking, this caused
> errors as multiple definitions of printk existed.
> Make sure _SHARED alone gives you only the printk prototype, and iff
> _MAINOBJECT is defined as well, include the assignment.
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

I like it, but I suggest to simplify the code further.

On top of your sign-off, add
Signed-off-by: Stefan Reinauer <stepan at coresystems.de>

coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v3_fix.diff
Type: text/x-patch
Size: 9020 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20071123/0324fd43/attachment.diff>

More information about the coreboot mailing list