[LinuxBIOS] question on lx raminit.c
Marc.Jones at AMD.com
Mon Oct 22 06:59:17 CEST 2007
Carl-Daniel Hailfinger wrote:
> On 20.10.2007 02:44, ron minnich wrote:
>> I offer the following diff and a question: can the use of && in these
>> if expressions be wrong?
>> Currently it is:
>> if ((MIN_MOD_BANKS > spd_byte) && (spd_byte > MAX_MOD_BANKS))
> You want || because either condition should cause the error message. The
> current statement will never be true because
> (MIN_MOD_BANKS > MAX_MOD_BANKS) is never true.
> Patch looks fine to me.
> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
Indeed, I didn't test it with an non-supported dimm....
Senior Firmware Engineer
(970) 226-9684 Office
mailto:Marc.Jones at amd.com
More information about the coreboot