[coreboot] [patch][v2][3/4] Family 10

[Stefan Reinauer]

* Marc Jones <Marc.Jones at amd.com> [080416 19:47]:
> Find matching settings for each CPUs FID, VID, and P-state registers and
> initialize them. Supports single and split plane systems. Set P0 on all
> cores for best performance. All APs will be in hlt(C1).
> 
> The platform warm rest logic has been updated to alway reset for HT and
> FID/VID setup. It is not optional anymore.
> 
> Signed-off-by: Marc Jones (marc.jones at amd.com)
                            ^^^^^^^^^^^^^^^^^^^^^
The script checks for <> instead of () so be careful when checking in..
:-)
 
Acked-by: Stefan Reinauer <stepan at coresystems.de>

  
> +
> +static void recalculateVsSlamTimeSettingOnCorePre(device_t dev)

:-)) I like the idea of documentation in the function name. But at some
point it would be nice to say a word of two in an additional comment,
possibly in Doxygen style

/**
 * ...
 */




-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866