[coreboot] r3818 build service
mylesgw at gmail.com
Fri Dec 19 04:13:38 CET 2008
On Thu, Dec 18, 2008 at 5:16 PM, Marc Jones <marcj303 at gmail.com> wrote:
> On Thu, Dec 18, 2008 at 12:10 PM, Myles Watson <mylesgw at gmail.com> wrote:
> > On Thu, Dec 18, 2008 at 11:42 AM, coreboot information <
> info at coresystems.de>
> > wrote:
> >> Dear coreboot readers!
> >> This is the automated build check service of coreboot.
> >> The developer "myles" checked in revision 3818 to
> >> the coreboot source repository and caused the following
> >> changes:
> >> Change Log:
> >> This patch gets rid of all the implicit definition warnings for
> >> except get_nodes.
> >> Signed-off-by: Myles Watson <mylesgw at gmail.com>
> >> Acked-by: Marc Jones <marcj303 at gmail.com>
> >> Build Log:
> >> Compilation of asus:m2v-mx_se has been broken
> >> See the error log at
> > Should this board have HAVE_HARD_RESET 1? That fixes the build. If not,
> > I'm not sure how to fix the macro definition of hard_reset in
> > src/include/part/hard_reset.h. It seems strange to hang without a
> > but that's not what's causing the build failure.
> Yes, I think that is the problem. It has a hard reset function in
> cache_as_ram_auto.c but the function is empty. Remove the function and
> leave the macro?
Then the build is still broken. The empty function says that the board
should have a hard_reset, but it's not implemented. I think the right thing
to do is define HAVE_HARD_RESET and add a #warning that it isn't
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the coreboot