[coreboot] [PATCH] v3: convert fake SPD to struct spd_entry
stepan at coresystems.de
Fri Feb 29 22:16:38 CET 2008
* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [080229 22:04]:
>> 85% of 128 bytes? Therefore this is O(n) now instead of O(1) in ROM
>> accesses. Are you sure?
> Well, since we need the fake SPD in initram, we can't compress it and
> really lose that space in ROM. That's why I decided to accept higher lookup
> cost to achieve space savings. However, if anybody can show that the
> increased code complexity costs us more ROM space than what we save by
> converting the data structure from a direct access array to an iterated
> list, I'm all for changing it back.
Oh I had assumed you had already analyzed the code space savings before
claiming your method saves 85% by running in a loop instead of once.
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
More information about the coreboot