[coreboot] [PATCH] Cleanup/remove update_ssdt

Stefan Reinauer stepan at coresystems.de
Sun Feb 1 19:02:49 CET 2009


Peter Stuge wrote:
> Rudolf Marek wrote:
>   
>> +++ coreboot-v2/src/mainboard/agami/aruma/acpi_tables.c	2009-02-01 12:04:04.738807653 +0100
>> @@ -15,6 +15,7 @@
>>  #include <device/pci_ids.h>
>>  #include <cpu/x86/msr.h>
>>  #include <cpu/amd/mtrr.h>
>> +#include <../../../northbridge/amd/amdk8/amdk8_acpi.h>
>>     
>
> ../../../ that can't be right. Maybe the .h should go into include/
> somewhere instead?
>   
I don't think I can agree... northbridge specific code should really
really live under northbridge.

Whether we want to add some syntactic sugar to make it look nicer than
the above is another question.


Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866





More information about the coreboot mailing list