[coreboot] [PATCH] Cleanup/remove update_ssdt
rminnich at gmail.com
Sun Feb 1 19:04:50 CET 2009
On Sun, Feb 1, 2009 at 10:02 AM, Stefan Reinauer <stepan at coresystems.de> wrote:
> Peter Stuge wrote:
>> Rudolf Marek wrote:
>>> +++ coreboot-v2/src/mainboard/agami/aruma/acpi_tables.c 2009-02-01 12:04:04.738807653 +0100
>>> @@ -15,6 +15,7 @@
>>> #include <device/pci_ids.h>
>>> #include <cpu/x86/msr.h>
>>> #include <cpu/amd/mtrr.h>
>>> +#include <../../../northbridge/amd/amdk8/amdk8_acpi.h>
>> ../../../ that can't be right. Maybe the .h should go into include/
>> somewhere instead?
> I don't think I can agree... northbridge specific code should really
> really live under northbridge.
> Whether we want to add some syntactic sugar to make it look nicer than
> the above is another question.
If it's a huge concern add a -I for that directory in the CFLAGS.
More information about the coreboot