[coreboot] [PATCH] Add QWord support to acpigen

Rudolf Marek r.marek at assembler.cz
Tue Feb 17 00:10:08 CET 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Carl-Daniel Hailfinger wrote:
> Add QWord support to acpigen.
> 
> Add TOM2 to the K8 DSDT.
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> 
> Compile tested only.

Hi, thanks for doing this. However there are two issues.

1) the opcode is 0xe and not 0xd
2) the << 32 must be cast to unit64_t first.

I'm attaching patch here. It works otherwise!

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmZ8k8ACgkQ3J9wPJqZRNUbtQCguWFybWRu5NoGZtXY02mpPghE
SqwAnAkGb1IVX6STwU3z/TNr2CaMG7Of
=azgs
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: from_carldani.patch
Type: text/x-diff
Size: 2537 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090217/14121b9f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: from_carldani.patch.sig
Type: application/octet-stream
Size: 72 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090217/14121b9f/attachment.obj>


More information about the coreboot mailing list