[coreboot] [PATCH] Add QWord support to acpigen

Peter Stuge peter at stuge.se
Tue Feb 17 02:59:50 CET 2009


Rudolf Marek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Carl-Daniel Hailfinger wrote:
> > Add QWord support to acpigen.
> > 
> > Add TOM2 to the K8 DSDT.
> > 
> > Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
> > 
> > Compile tested only.
> 
> Hi, thanks for doing this. However there are two issues.
> 
> 1) the opcode is 0xe and not 0xd
> 2) the << 32 must be cast to unit64_t first.
> 
> I'm attaching patch here. It works otherwise!

Maybe add a signed-off-by Rudolf?

Acked-by: Peter Stuge <peter at stuge.se>




More information about the coreboot mailing list