[coreboot] [PATCH] Add QWord support to acpigen
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Tue Feb 17 22:39:20 CET 2009
On 17.02.2009 02:59, Peter Stuge wrote:
> Rudolf Marek wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Carl-Daniel Hailfinger wrote:
>>
>>> Add QWord support to acpigen.
>>>
>>> Add TOM2 to the K8 DSDT.
>>>
>>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>>>
>>> Compile tested only.
>>>
>> Hi, thanks for doing this. However there are two issues.
>>
>> 1) the opcode is 0xe and not 0xd
>> 2) the << 32 must be cast to unit64_t first.
>>
>> I'm attaching patch here. It works otherwise!
>>
>
> Maybe add a signed-off-by Rudolf?
>
> Acked-by: Peter Stuge <peter at stuge.se>
>
Thanks, r3953.
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
More information about the coreboot
mailing list